From ac246bd6c2a7b6ef4897d1185853cf75bb2e01bf Mon Sep 17 00:00:00 2001 From: aikai Date: Tue, 8 Apr 2025 16:27:05 +0800 Subject: [PATCH] =?UTF-8?q?refactor(zn-module-smartfactory):=20=E9=87=8D?= =?UTF-8?q?=E6=9E=84=20HandlingGroupUserAmountServiceImpl=20=E7=B1=BB?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 提取常量：将 userId、nickName 和 totalAmount 提取为类常量 - 优化代码可读性：使用常量替换硬编码字符串 --- .../HandlingGroupUserAmountServiceImpl.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/zn-module-smartfactory/zn-module-smartfactory-biz/src/main/java/cn/iocoder/yudao/module/smartfactory/service/handlinggroupuseramount/HandlingGroupUserAmountServiceImpl.java b/zn-module-smartfactory/zn-module-smartfactory-biz/src/main/java/cn/iocoder/yudao/module/smartfactory/service/handlinggroupuseramount/HandlingGroupUserAmountServiceImpl.java index f1a50f3e..7ef6de3e 100644 --- a/zn-module-smartfactory/zn-module-smartfactory-biz/src/main/java/cn/iocoder/yudao/module/smartfactory/service/handlinggroupuseramount/HandlingGroupUserAmountServiceImpl.java +++ b/zn-module-smartfactory/zn-module-smartfactory-biz/src/main/java/cn/iocoder/yudao/module/smartfactory/service/handlinggroupuseramount/HandlingGroupUserAmountServiceImpl.java @@ -37,6 +37,10 @@ public class HandlingGroupUserAmountServiceImpl implements HandlingGroupUserAmou private HandlingGroupAmountSpecificationsMapper handlingGroupAmountSpecificationsMapper; private static final String NAME = "姓名"; private static final String TOTAL_AMOUNT = "总金额"; + // 提取常量 + private static final String USER_ID = "userId"; + private static final String NICK_NAME = "nickName"; + private static final String TOTAL_AMOUNT_EN = "totalAmount"; @Override public Long createHandlingGroupUserAmount(HandlingGroupUserAmountSaveReqVO createReqVO) { @@ -116,15 +120,15 @@ public class HandlingGroupUserAmountServiceImpl implements HandlingGroupUserAmou List list = new ArrayList<>(); for (Map item : map) { HandlingGroupUserAmountMonthItemVO itemVO = new HandlingGroupUserAmountMonthItemVO(); - itemVO.setUserId((Long) item.get("userId")); + itemVO.setUserId((Long) item.get(USER_ID)); Map itemMap = new HashMap<>(); - itemMap.put(1, item.get("nickName").toString()); + itemMap.put(1, item.get(NICK_NAME).toString()); num = 1; for (String date : dateList) { num++; itemMap.put(num, item.get(date).toString()); } - itemMap.put(num + 1, item.get("totalAmount").toString()); + itemMap.put(num + 1, item.get(TOTAL_AMOUNT_EN).toString()); itemVO.setContentList(itemMap); list.add(itemVO); }